> -----Original Message----- > From: Jason Gunthorpe [mailto:jgg@xxxxxxxx] > Sent: Monday, January 15, 2018 4:08 PM > To: Leon Romanovsky <leon@xxxxxxxxxx> > Cc: Doug Ledford <dledford@xxxxxxxxxx>; RDMA mailing list <linux- > rdma@xxxxxxxxxxxxxxx>; Daniel Jurgens <danielj@xxxxxxxxxxxx>; Parav Pandit > <parav@xxxxxxxxxxxx> > Subject: Re: [PATCH rdma-next 1/3] RDMA/core: Remove RoCE support from > rdma_addr_get_sgid() > > On Tue, Jan 09, 2018 at 01:10:56PM +0200, Leon Romanovsky wrote: > > From: Parav Pandit <parav@xxxxxxxxxxxx> > > > > There are number of issues with RoCE support in rdma_addr_get_sgid() call: > > > > 1. With IP based GIDs, SGID derived using iboe_addr_get_sgid() was not > > used in connection establishment process. SGID was always derived > > using ip2gid(). > > > > 2. It returns the first IP address of the netdevice, while netdevice > > can have multiple IP addresses and connection could have been > > established using non first IP address. > > > > 3. It returns SGID based on IPv4 address. It doesn't cover IPv6 addresses. > > > > 4. As the comment of rdma_dev_addr src_dev_addr and dst_dev_addr > > suggest, such members of rdma_dev_addr stores the mac address. > > Therefore it is not the best place to store the RoCE GIDs. RoCE GIDs > > are derived from the IP addresses and they are already available in cm_id- > >route->addr.***_addr. > > > > It was only used to return SGID to rds/ib.c and ucma.c modules, where > > it returned incorrect SGID in above matching conditions. > > Yes, but if those conditions were not matched it did something useful and now > what happens? Now it returns correct SGID in matched and unmatched cases. > > All the callers in ucma.c are returning the result to userspace, so this patch looks > like it is changing the uapi in some way? No. It doesn't change uapi. It fixes cases by returning appropriate GID. > > Can you define what the SGID/DGID should be in the rdma CM uapi when > working with rocee? > It is the GIDs derived from the IP address using ip2gid() conversion. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
