On 1/2/2018 9:26 AM, Leon Romanovsky wrote: > On Tue, Jan 02, 2018 at 09:18:59AM -0500, Hal Rosenstock wrote: >> On 12/28/2017 12:30 AM, Leon Romanovsky wrote: >>> On Wed, Dec 27, 2017 at 01:19:45PM -0700, Jason Gunthorpe wrote: >>>> On Mon, Dec 25, 2017 at 02:31:32PM +0200, Leon Romanovsky wrote: >>>>> From: Leon Romanovsky <leonro@xxxxxxxxxxxx> >>>>> >>>>> The libibcm library was marked as obsolete long time ago, >>>>> the following patch is first step before removing ucm from >>>>> the kernel. >>>> >>>> I understand the distros will not want to loose libibcm in their >>>> stable releases. >>>> >>>> It might make more sense instead to just not build libibcm by default >>>> with a cmake option but still keep the sources.. >>> >>> We are not removing it from the stable branches, so if they want to keep it >>> till last person who used this library dies, they are free to do it. >>> >>> The disabled build doesn't give much benefit at all. It will be dead code exactly >>> as now, but without any alert that it is broken. Most possible, it will be broken >>> till some distro will notice it. >> >> Since when has it been broken and how is it broken ? Last I knew it >> worked but was not used by anything in tree. > > Hal, > > Where did you see me saying that it is broken? > > I said that it WILL be broken if we don't compile it by default. OK but that's not how I interpreted what you wrote: "It will be dead code exactly as now, but without any alert that it is broken." Anyhow, if distro still wants to include this, wouldn't they build and test it ? -- Hal > Thanks > >> >> -- Hal >> >>> Exactly as some distros have EOL, this libibcm library came to its EOL. >>> >>> Thanks >>> >>>> >>>> Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html