On Thu, Dec 21, 2017 at 07:42:16AM +0200, Leon Romanovsky wrote: > Both these functions are performing their checks of cq_attr->comp_mask, > but return different errno. I think that it is perfect timing to start > organize and unite our return errors. They should return the same errno. Bugs bugs everywhere.. This is going to be another patch. I would drop the errno set into check_comp_mask and change all comp_mask users to call it, and probably drop the _RESERVED uglyness too, but another patch. > > In the case of ibv_queryrt_values_ex, there is no check in the function > > op, which is an ABI mistake. So move the check there. > > ibv_queryrt_values_ex -> ibv_query_rt_values_ex K.. Are you going to collect the loose patches on the list? Can you fix the typo when you grab this one :) Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
