On Wed, Dec 20, 2017 at 08:22:21PM +0200, Yuval Shaia wrote: > On Tue, Dec 19, 2017 at 09:14:05AM +0000, Amrani, Ram wrote: > > > Hi Jason, Yuval, > > > I’ve started a review on this a couple of days ago. It’s the first time I’ve done this. > > > Did you get e-mails about it? How come it gets merged without response? > > > Please comment on my remarks. > > > > > > Thanks, > > > Ram > > > > > > > I still didn't see any e-mail. > > Probably the review doesn't work after the patch has been committed. > > Have no idea why? > So, for rdma-core, i understood that PR on github is much more powerful > than linux-rdma mailing list but i don't mind running on both next time. PR emails only go to a few people. I saw an email notice from Ram after he posted his review.. Perhaps the submitter is not included after the PR is closed? Maybe your github notifications are not working? This limited audiance is a big part of why Leon asks for patches to be sent to the mailing list as well as in a PR.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
