> Hi Jason, Yuval,
> I’ve started a review on this a couple of days ago. It’s the first time I’ve done this.
> Did you get e-mails about it? How come it gets merged without response?
> Please comment on my remarks.
>
> Thanks,
> Ram
>
I still didn't see any e-mail.
Probably the review doesn't work after the patch has been committed.
My comments:
+ printf(" -c, --chk validate received buffer\n");
Why not have the default set to 'validate'?
The only reason not to use validate is for performance and I don't think this application checks that...
Still, if this is important then the user can choose to disable validation.
+ for (int i = 0; i < size; i += page_size)
I expect (and IMHO users expect too) that data validation is on the entire buffer. What is happening here is that only a single byte per page is checked.
Thanks,
Ram
��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
