On Tue, Dec 19, 2017 at 08:20:50PM +0800, Honggang LI wrote: > > Here is a sketch on how to fix it properly. All the users of > > pthread_kill should be eliminated. > > > > Though overall, there is really no reason to even cleanup the threads, > > just call exit? > > No, if one pthread just calls 'exit', the entire process will be > terminated immediately. So, we need to cleanup the threads. > > I think the source of current issue is the async_ev_thread pthread. > We should *NOT* create such pthread for ibsrpdm. > > I checked the old srptools git repo. FYI, this is merged into rdma-core, use git log -p --follow srp_daemon/srp_daemon.c and it will show you full history on a single file. > Commit ab57a5b92eb3b8c9221f77235a028814a462d2cb merges "ibsrpdm" into > "srp_daemon". The old ibsrpdm program is a single thread program. > srp_daemon is multi-thread program. Makes sense that ibsrpdm does not need the run_thread_listen_to_events() thread. Patch looks OK to me too. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
