On Tue, Dec 19, 2017 at 04:57:35PM +0000, Bart Van Assche wrote:
> On Tue, 2017-12-19 at 20:20 +0800, Honggang LI wrote:
> > As ibsrpdm always only run once, because "config->once" has been
> > assigned to 1. I would suggest to apply this patch.
> >
> > diff --git a/srp_daemon/srp_daemon.c b/srp_daemon/srp_daemon.c
> > index cec36db2..4012a7db 100644
> > --- a/srp_daemon/srp_daemon.c
> > +++ b/srp_daemon/srp_daemon.c
> > @@ -1945,12 +1945,12 @@ static struct resources *alloc_res(void)
> > run_thread_get_trap_notices, &res->res);
> > if (ret)
> > goto err;
> > - }
> >
> > - ret = pthread_create(&res->res.async_ev_thread, NULL,
> > - run_thread_listen_to_events, &res->res);
> > - if (ret)
> > - goto err;
> > + ret = pthread_create(&res->res.async_ev_thread, NULL,
> > + run_thread_listen_to_events, &res->res);
> > + if (ret)
> > + goto err;
> > + }
> >
> > if (config->retry_timeout && !config->once) {
> > ret = pthread_create(&res->res.reconnect_thread, NULL,
>
> Please submit this as a proper patch and add the following:
[rdma-core PATCH] srp_daemon: Don't create async_ev_thread if only run once
I sent the patch with that $SUBJECT.
thanks
> Reviewed-by: Bart Van Assche <bart.vanassche@xxxxxxx>
>
> Thanks,
>
> Bart.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
