Le 06/12/2017 à 18:13, Jason Gunthorpe a écrit :
> On Wed, Dec 06, 2017 at 09:00:50AM +0100, Nicolas Morey-Chaisemartin wrote:
>>
>> Le 06/12/2017 à 00:40, Tatyana Nikolova a écrit :
>>> Without systemd-devel, all rdma-core daemons are using shim version of
>>> systemd include file (in-turn, shim version of systemd functions)
>>> causing them to not communicate with systemd.
>>>
>>> Add the missing required systemd-devel package to SUSE's rdma-core.spec
>>> so the correct header file is used and correct functions are linked
>>> with the daemons.
>>>
>>> Fixes: 8854eefa60b5 ("suse: Add spec file for SUSE")
>>> Signed-off-by: Tatyana Nikolova <tatyana.e.nikolova@xxxxxxxxx>
>>> suse/rdma-core.spec | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/suse/rdma-core.spec b/suse/rdma-core.spec
>>> index 0eba0507..912a77c5 100644
>>> +++ b/suse/rdma-core.spec
>>> @@ -57,6 +57,7 @@ BuildRequires: pkgconfig
>>> BuildRequires: pkgconfig(libsystemd)
>>> BuildRequires: pkgconfig(libudev)
>>> BuildRequires: pkgconfig(systemd)
>>> +BuildRequires: pkgconfig(systemd-devel)
>>> BuildRequires: pkgconfig(udev)
>>> BuildRequires: python3-base
>>> %ifnarch s390 s390x
>> You should not need that.
>> This is what this line is for:
>>
>> BuildRequires: pkgconfig(systemd)
> I actually think pkgconfig(systemd) is a mistake in the spec file..
>
> This brings in the libraries:
>
> BuildRequires: pkgconfig(libsystemd)
>
> This is does something else and isn't needed, AFAIK:
>
> BuildRequires: pkgconfig(systemd)
I just checked:
This pulls in systemd (or systemd-mini)
And pkgconfig(udev) pulls udev or udev-mini.
So they are not compulsory build requirements (as we require the -devel they should be installed by dependency) but they don't hurt.
>
> Probably something like
>
> BuildRequires: pkgconfig(libsystemd) | (pkgconfig(libsystemd-journal), pkgconfig(libsystemd-id128), pkgconfig(libsystemd-daemon))
On a recent systemd, systemd-devel provides all those (probably for compat reason during migration):
$ rpm -q --provides systemd-devel
pkgconfig(libsystemd) = 228
pkgconfig(libsystemd-daemon) = 228
pkgconfig(libsystemd-id128) = 228
pkgconfig(libsystemd-journal) = 228
pkgconfig(libsystemd-login) = 228
So I can porobably safely changes the BuildRequires to the libsystemd-XXXX.
If I'm not mistaken, we just need the -daemon and -journal ones.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
