On Wed, Dec 06, 2017 at 09:00:50AM +0100, Nicolas Morey-Chaisemartin wrote:
>
>
> Le 06/12/2017 à 00:40, Tatyana Nikolova a écrit :
> > Without systemd-devel, all rdma-core daemons are using shim version of
> > systemd include file (in-turn, shim version of systemd functions)
> > causing them to not communicate with systemd.
> >
> > Add the missing required systemd-devel package to SUSE's rdma-core.spec
> > so the correct header file is used and correct functions are linked
> > with the daemons.
> >
> > Fixes: 8854eefa60b5 ("suse: Add spec file for SUSE")
> > Signed-off-by: Tatyana Nikolova <tatyana.e.nikolova@xxxxxxxxx>
> > suse/rdma-core.spec | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/suse/rdma-core.spec b/suse/rdma-core.spec
> > index 0eba0507..912a77c5 100644
> > +++ b/suse/rdma-core.spec
> > @@ -57,6 +57,7 @@ BuildRequires: pkgconfig
> > BuildRequires: pkgconfig(libsystemd)
> > BuildRequires: pkgconfig(libudev)
> > BuildRequires: pkgconfig(systemd)
> > +BuildRequires: pkgconfig(systemd-devel)
> > BuildRequires: pkgconfig(udev)
> > BuildRequires: python3-base
> > %ifnarch s390 s390x
>
> You should not need that.
> This is what this line is for:
>
> BuildRequires: pkgconfig(systemd)
I actually think pkgconfig(systemd) is a mistake in the spec file..
This brings in the libraries:
BuildRequires: pkgconfig(libsystemd)
This is does something else and isn't needed, AFAIK:
BuildRequires: pkgconfig(systemd)
Same with udev:
BuildRequires: pkgconfig(libudev)
vs
BuildRequires: pkgconfig(udev)
But you explained in the past suse needed actual udev installed for some
reason I can't remember..
> We don't expressly name systemd-devel and use the pkgconfig macro to
> allow building using systemd-mini-devel when needed.
I suspect Tatyana has an old version of suse where
'pkgconfig(libsystemd)' doesn't do the right thing.
I suspect the issue is that old versions of suse probably have the old
arrangement of systemd libraries that were split into three libraries
(libsystemd-journal, libsystemd-id128, and libsystemd-daemon)
so pkgconfig(libsystemd) isn't going to work (and rpmbuild should fail
fail, why doesn't it??)
Probably something like
BuildRequires: pkgconfig(libsystemd) | (pkgconfig(libsystemd-journal), pkgconfig(libsystemd-id128), pkgconfig(libsystemd-daemon))
If RPM can do that, otherwise a suse version conditional?
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
