> -----Original Message----- > From: Jason Gunthorpe [mailto:jgg@xxxxxxxxxxxx] > Sent: Wednesday, December 06, 2017 11:28 AM > To: Nicolas Morey-Chaisemartin <NMoreyChaisemartin@xxxxxxx> > Cc: Nikolova, Tatyana E <tatyana.e.nikolova@xxxxxxxxx>; > dledford@xxxxxxxxxx; leonro@xxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; > e1000-rdma@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH] rdma-core: Add missing systemd-devel dependency to > the SUSE rdma-core.spec > > On Wed, Dec 06, 2017 at 06:24:20PM +0100, Nicolas Morey-Chaisemartin > wrote: > > > > This is does something else and isn't needed, AFAIK: > > > > > > BuildRequires: pkgconfig(systemd) > > > > This was requested by the main OpenSUSE maintainer so I blindly > > trusted him with this :) I'll still ask him if both are really needed > > (and if yes, what's the diff) > > I would anticipate this is the reason: > > Our build systems checks that scriptlets call existing binaries. > Without udev, udevadm does not exists which gets some errors in the > build logs. > > As we also call systemd binaries in various places. > > > Tatyana, could you give some more info on what prompted this patch ? > > +1 > The patch was prompted when the rdma-core daemons were unable to start on a SLES12SP2 system, because the shim version of the systemd functions were used instead. Unfortunately I don't have the details on how rdma-core was installed on this system. Checking the current SUSE spec file on the same system (without systemd-devel installed), it indeed detects a missing dependency: "error: Failed build dependencies: pkgconfig(libsystemd) is needed by rdma-core-15-0.x86_64" However libsystemd packages (libsystemd0-228-117.12.x86_64 and libsystemd0-32bit-228-117.12.x86_64) are installed on this system, but systemd-devel is necessary to install the required headers, for example "sd-daemon.h" needed by the daemons. Maybe it would be better to replace pkgconfig(libsystemd) with pkgconfig(systemd-devel) in the spec file, since systemd-devel requires libsystemd? Thank you, Tatyana > Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
