On Wed, Nov 22, 2017 at 05:47:42PM +0000, Alex Margolin wrote: > To follow up on the previous discussion, > we changed the RFC proposal to focus on this single type for vendor QP. Okay.. So in future sending MIME attached patches is very hard to do anything with.. I have provided my comments as best I can below: - The QPT should be IB_QPT_DRIVER Please scrub the word 'vendor' from your vocabulary and all patches. Everything is *DRIVER* specific if it uses the dv interface. - It makes me annoyed that 'enum ib_qp_type' is not in a uapi header, please consider sending a patch to fix this while you are touching this area - I don't know if having a huge multiplex 'mlx5dv_create_qp' is such a great idea. Since the DV API is linked, it would make more sense to have a specially 'mlx5dv_create_dct' sort of API so that we have better visibility on what the app needs of the dv library. Eg a dct using app will fail to link on older dv libraries. - The libmlx5.map is wrong.. Otherwise, this is broadly what I had in mind when we talked about this at the last conference. The idea is to simply shunt eveything to the driver path until someone bothers to standadize the features. DC will not be exposed to the core RDMA code in the kernel. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
