> + if (wc->wc_flags & IB_WC_WITH_INVALIDATE) {
> + if (unlikely(wc->ex.invalidate_rkey == req->mr->rkey)) {
The == here should be a != I think.
> + dev_err(queue->ctrl->ctrl.device,
> + "Bogus remote invalidation for rkey %#x\n",
> + req->mr->rkey);
> + nvme_rdma_error_recovery(queue->ctrl);
> + }
> req->mr->need_inval = false;
> - refcount_dec(&req->ref);
> } else if (req->mr->need_inval) {
> ret = nvme_rdma_inv_rkey(queue, req);
> if (unlikely(ret < 0)) {
> @@ -1347,6 +1349,8 @@ static int nvme_rdma_process_nvme_rsp(struct
> nvme_rdma_queue *queue,
> req->mr->rkey, ret);
> nvme_rdma_error_recovery(queue->ctrl);
> }
> + /* return here as we can't really end the request */
> + return 0;
Maybe replace the comment with
/* the local invalidation completion will end the request */
Otherwise this looks fine to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
