On Wed, Nov 15, 2017 at 06:52:49PM +0100, Nicolas Morey-Chaisemartin wrote: > > > Le 15/11/2017 à 18:37, Leon Romanovsky a écrit : > > On Wed, Nov 15, 2017 at 06:22:33PM +0100, Nicolas Morey-Chaisemartin wrote: > >> > >> Le 15/11/2017 à 06:56, Leon Romanovsky a écrit : > >>> On Tue, Nov 14, 2017 at 07:57:55PM +0100, Nicolas Morey-Chaisemartin wrote: > >>>> Builds rdma-core in -Og/Debug mode and use abi-dumper to generate 1 xml > >>>> per .so.*.* file. > >>>> Do not use .so file directly. Providers have no symbol exported > >>>> and cause abi-dumer to exit with an error. > >>> mlx4/mlx5 do export. > >>> > >>> Thanks > >> > >> Yes but they also export versiones .so files > >> $ ll build-abi/lib/libmlx* > >> lrwxrwxrwx 1 nmorey users 17 Nov 14 19:51 build-abi/lib/libmlx4-rdmav16.so -> libmlx4.so.1.0.16 > >> lrwxrwxrwx 1 nmorey users 12 Nov 14 19:51 build-abi/lib/libmlx4.so -> libmlx4.so.1 > >> lrwxrwxrwx 1 nmorey users 17 Nov 14 19:51 build-abi/lib/libmlx4.so.1 -> libmlx4.so.1.0.16 > >> -rwxr-xr-x 1 nmorey users 276600 Nov 14 19:51 build-abi/lib/libmlx4.so.1.0.16 > >> lrwxrwxrwx 1 nmorey users 17 Nov 14 19:51 build-abi/lib/libmlx5-rdmav16.so -> libmlx5.so.1.2.16 > >> lrwxrwxrwx 1 nmorey users 12 Nov 14 19:51 build-abi/lib/libmlx5.so -> libmlx5.so.1 > >> lrwxrwxrwx 1 nmorey users 17 Nov 14 19:51 build-abi/lib/libmlx5.so.1 -> libmlx5.so.1.2.16 > >> -rwxr-xr-x 1 nmorey users 690712 Nov 14 19:51 build-abi/lib/libmlx5.so.1.2.16 > >> > >> So the .so are ignored (specially the -rdmav16) but the standalone ones aren't > > We are supporting static builds too (*.a and not *.so), can the script > > be extended to check them too? > > > > Thanks > > Does that changes something ? As long as the specific build-abi build generates the .so, it should be sufficient to check the ABI. > Wether someone build with static options or not. > Unless there are other static libs I'm missing. In static libraries, the functions have different signatures without stanzas. > > Nicolas
Attachment:
signature.asc
Description: PGP signature
