Hi Jason, > -----Original Message----- > From: Jason Gunthorpe [mailto:jgg@xxxxxxxx] > Sent: Tuesday, November 14, 2017 6:33 PM > To: Leon Romanovsky <leon@xxxxxxxxxx> > Cc: Doug Ledford <dledford@xxxxxxxxxx>; linux-rdma@xxxxxxxxxxxxxxx; Parav > Pandit <parav@xxxxxxxxxxxx> > Subject: Re: [PATCH rdma-next 03/31] IB/core: Depend on IPv6 stack to resolve > link local address > > On Tue, Nov 14, 2017 at 02:51:50PM +0200, Leon Romanovsky wrote: > > From: Parav Pandit <parav@xxxxxxxxxxxx> > > > > Currently ib_resolve_eth_dmac() bypasses IPv6 stack for resolving link > > local destination mac address and translates the IPv6 link local GID > > to MAC address, which is not always correct. > > Static link local neighbour entry can be setup using ip -6 neigh add > > <link_local_addr> lladdr <mac_addr> dev eth0 Current code bypasses > > such administratively set entries and IPV6 stack. > > At the very least this description makes little sense. > > The code is inspecting a DGID, and when in rocev1 mode, the DGID is And it is inspecting SGID type too as rocev1 or v2 using below check. sgid_attr.gid_type == IB_GID_TYPE_ROCE > *NOT* an IPv6 address and the correct thing to do is what it is doing now. > Yes. It does what it does today. When SGID is RoCEv1, it doesn't do ND. > In rocev2 mode the DGID becomes and IPv6 address and you should do ND. > > Has this distinction been captured in the patch? Yes. When SGID type is RoCEv2, it performs ARP/ND. This is described in commit log - it uses rdma_addr_find_l2_eth_by_grh() which performs ND. > > Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
