Hi Jason, > -----Original Message----- > From: Jason Gunthorpe [mailto:jgg@xxxxxxxx] > Sent: Tuesday, November 14, 2017 6:18 PM > To: Leon Romanovsky <leon@xxxxxxxxxx> > Cc: Doug Ledford <dledford@xxxxxxxxxx>; linux-rdma@xxxxxxxxxxxxxxx; Parav > Pandit <parav@xxxxxxxxxxxx> > Subject: Re: [PATCH rdma-next 01/31] IB/core: Fix do not add RoCEv2 default > GID when IPv6 is disabled > > On Tue, Nov 14, 2017 at 02:51:48PM +0200, Leon Romanovsky wrote: > > > + /* Default GID is created using unique GUID and local subnet prefix, > > + * as described in section 4.1.1 and 3.5.10 in IB spec 1.3. > > + * Therefore don't create RoCEv2 default GID based on it that > > + * resembles as IPv6 GID based on link local address when IPv6 is > > + * disabled in kernel. > > + */ > > + if (!IS_ENABLED(CONFIG_IPV6)) > > + gid_type_mask &= ~BIT(IB_GID_TYPE_ROCE_UDP_ENCAP); > > There is also a sysctl to globally disable ipv6, I would think it would be better to > check than then a CONFIG symbol? > Currently in rest of the IB stack in cma.c, addr.c we check for IS_ENABLED(CONFIG_IPV6). May be when all of them are changed, this can also shift to honoring sysctl. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
