On Fri, Nov 10, 2017 at 02:15:29PM -0500, Doug Ledford wrote: > signature of ib_modify_cq to a generic, extendable signature, or we need > to change the name as Jason points out so we match name and parameter > signature in the same spirit. The kernel side should focus on setting cq moderation, as I understand we have ULPs that want to adjust this dynamically so higher performance through a simplified API makes the most sense. No need to mirror libibverbs. > Let's please make this consistent before merging. BTW, because so much > of the rest of the API uses things like modify_qp with an attr struct > and a single entry point, I'm leaning towards following that here for > the sake of API consistency. Should we introduce a create_cq_ex as well at this point? It is really weird in verbs to have a modify attrs without a create also accepting the attrs. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
