On Thu, Oct 26, 2017 at 01:06:34PM +0300, Leon Romanovsky wrote: > On Thu, Oct 26, 2017 at 09:47:44AM +0000, Denis Drozdov wrote: > > Temporary commit that blocks pkey creation using > > ip link. Example: > > > > ip link add link ib2 name ib2.1 type ipoib > > RTNETLINK answers: Operation not supported > > > > Signed-off-by: Feras Daoud <ferasda@xxxxxxxxxxxx> > > Signed-off-by: Denis Drozdov <denisd@xxxxxxxxxxxx> > > drivers/infiniband/ulp/ipoib/ipoib_netlink.c | 3 +++ > > 1 file changed, 3 insertions(+) > > NAK, > It is completely wrong and this bug relevant for mlx5 enhanced IPoIB devices, > but you are disabling all IPoIB capable devices. +1 If this flow doesn't work with netdev offload, then disable the entire netdev offload completely until it can be fixed properly. It is absolutely not OK to selectively break established user APIs like 'ip link' just because a kernel-side optimization is not implemented correctly, you don't get to do that. If we knew that the netdev offload patches broke 'ip link' they would not have been accepted. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
