On Thu, Oct 26, 2017 at 09:47:44AM +0000, Denis Drozdov wrote: > Temporary commit that blocks pkey creation using > ip link. Example: > > ip link add link ib2 name ib2.1 type ipoib > RTNETLINK answers: Operation not supported > > Signed-off-by: Feras Daoud <ferasda@xxxxxxxxxxxx> > Signed-off-by: Denis Drozdov <denisd@xxxxxxxxxxxx> > --- > drivers/infiniband/ulp/ipoib/ipoib_netlink.c | 3 +++ > 1 file changed, 3 insertions(+) NAK, It is completely wrong and this bug relevant for mlx5 enhanced IPoIB devices, but you are disabling all IPoIB capable devices. Thanks > > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_netlink.c b/drivers/infiniband/ulp/ipoib/ipoib_netlink.c > index dd1f256..b507a6e 100644 > --- a/drivers/infiniband/ulp/ipoib/ipoib_netlink.c > +++ b/drivers/infiniband/ulp/ipoib/ipoib_netlink.c > @@ -101,6 +101,9 @@ static int ipoib_new_child_link(struct net *src_net, struct net_device *dev, > u16 child_pkey; > int err; > > + /* TODO This change should be removed after adding netlink support */ > + return -EOPNOTSUPP; > + > if (!tb[IFLA_LINK]) > return -EINVAL; > > -- > 1.8.3.1 > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html
Attachment:
signature.asc
Description: PGP signature