Re: [PATCH 13/47] RDMA/cxgb4: Declare a local variable 'static'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2017-10-10 at 06:59 +0300, Leon Romanovsky wrote:
> On Mon, Oct 09, 2017 at 11:20:20PM +0000, Bart Van Assche wrote:
> > On Fri, 2017-10-06 at 17:09 -0500, Steve Wise wrote:
> > > Can we just remove this now?  IE has it been 1 release since it was obsoleted?
> > 
> > That's a good question but I'm not sure what would be a good time to remove
> > this. I think the answer depends on how likely it is that people use this
> > variable in scripts or /etc/modprobe.d configuration files because in that
> > case removing the module parameter would break setups.
> 
> It is unlikely to happen, for many reasons. It is marked as obsolete for
> a long time, the proper infrastructure (dynamic prints) already for a decade
> with us and no adequate user is running debug system in production.
> 
> Another thing that we do remove visible to user interfaces from time to time
> and the rule is "try to remove it and see if someone screams about it".
> 
> There are a lot of commits which do such thing and latest one is 0d0c71b31720
> ("btrfs: obsolete and remove mount option alloc_start")
> 
> It is safe to remove c4iw_debug module parameter.

OK, I will remove that module parameter.

Bart.��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux