Re: [PATCH 13/47] RDMA/cxgb4: Declare a local variable 'static'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2017-10-06 at 17:09 -0500, Steve Wise wrote:
> > 
> > Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx>
> > Cc: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
> > ---
> >  drivers/infiniband/hw/cxgb4/cm.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/infiniband/hw/cxgb4/cm.c
> 
> b/drivers/infiniband/hw/cxgb4/cm.c
> > index 2331e7d57704..49d9f9b870e5 100644
> > --- a/drivers/infiniband/hw/cxgb4/cm.c
> > +++ b/drivers/infiniband/hw/cxgb4/cm.c
> > @@ -99,7 +99,7 @@ module_param(enable_tcp_window_scaling, int, 0644);
> >  MODULE_PARM_DESC(enable_tcp_window_scaling,
> >  		 "Enable tcp window scaling (default=1)");
> > 
> > -int c4iw_debug;
> > +static int c4iw_debug;
> >  module_param(c4iw_debug, int, 0644);
> >  MODULE_PARM_DESC(c4iw_debug, "obsolete");
> 
> Can we just remove this now?  IE has it been 1 release since it was obsoleted?

That's a good question but I'm not sure what would be a good time to remove
this. I think the answer depends on how likely it is that people use this
variable in scripts or /etc/modprobe.d configuration files because in that
case removing the module parameter would break setups.

Bart.��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux