On Tue, 2017-10-10 at 14:15 +0000, Marciniszyn, Mike wrote:
> > Subject: [PATCH 40/47] IB/qib: Make qib_inc_eeprom_err() macro more safe
> > to use
> >
> > Avoid that using the qib_inc_eeprom_err() macro in an if-statement
> > triggers the following compiler warning:
> >
> > warning: suggest braces around empty body in an 'if' statement [-Wempty-
> > body]
> >
>
> There needs to be a follow-on patch here to get rid of the uses of this macro.
>
> The original fix got rid of a bad implementation, but should have totally
> removed both the function and its use.
>
> The is not the fault of this patch.
>
> Fixes: 18c0b82a3e45 (" IB/qib: Do not write EEPROM")
> Acked-by: Mike Marciniszyn <mike.marciniszyn@xxxxxxxxx>
Hello Mike,
How about dropping this patch and replacing it with a patch that removes all uses
of qib_inc_eeprom_err()?
Thanks,
Bart.��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
