Re: [PATCH 41/47] IB/qib: Suppress gcc 7 fall-through complaints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2017-10-10 at 13:56 +0000, Marciniszyn, Mike wrote:
> > Subject: [PATCH 41/47] IB/qib: Suppress gcc 7 fall-through complaints
> > 
> > Avoid that gcc 7 reports the following warning when building with W=1:
> > 
> > warning: this statement may fall through [-Wimplicit-fallthrough=]
> 
> I'm ok with this but...
> 
> I'm curious if there is a documentation change in the kernel on a common
> tree wide approach for gcc 7.
> 
> I saw a patch to add the attribute based method of getting rid of the warning,
> but it doesn't appear to have been merged.
> 
> This error probably runs through all of our drivers.
> 
> Acked-by: Mike Marciniszyn <mike.marciniszyn@xxxxxxxxx>

Hello Mike,

Thanks for the review. Regarding the tree-wide approach: there has already
been a discussion about this on various kernel-related mailing lists. See
also Linus Torvalds, Lots of new warnings with gcc-7.1.1, July 11, 2017
(https://www.mail-archive.com/netdev@xxxxxxxxxxxxxxx/msg177459.html). The
conclusion was that certain of these warnings should be suppressed but that
other warnings are useful and should be retained. See also commit
bd664f6b3e37 ("disable new gcc-7.1.1 warnings for now").

Bart.
��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux