On Mon, 2017-10-09 at 17:01 +0000, Bart Van Assche wrote: > On Mon, 2017-10-09 at 12:56 -0400, Doug Ledford wrote: > > On Sun, 2017-10-08 at 13:03 +0300, Leon Romanovsky wrote: > > > It is a little bit strange to ask from user to decide if his > > > adapter > > > supports SRQ or not. > > > > > > It should be automatically. > > > > I think Bart's intent is that the driver not use SRQ as the default > > behavior even if the adapter supports it, so querying the adapter > > for > > support and enabling it if it exists would not achieve his desired > > result. This would then be used to override that behavior. Is > > that > > correct Bart? > > Hello Leon and Doug, > > The changes realized by this patch are: > - Instead of using SRQ as default, use non-SRQ mode as default. > - If SRQ has been chosen as default, and if SRQ is not supported, > fall back > to non-SRQ mode (see also the if (IS_ERR(sdev->srq)) ... code). > > Please let me know if you have any further questions about this > patch. Nope, I'm good. -- Doug Ledford <dledford@xxxxxxxxxx> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html