On 10/4/2017 7:02 PM, Hefty, Sean wrote:
+static inline enum rdma_ah_attr_type rdma_ah_find_type(struct
+ib_device
*dev,
+ u32 port_num)
+{
+ if ((rdma_protocol_roce(dev, port_num)) ||
+ (rdma_protocol_iwarp(dev, port_num)))
+ return RDMA_AH_ATTR_TYPE_ROCE;
Check for iWarp to define AH attribute type as RoCE appears error
to me.
Taking quick look at i40iw and nes drivers appears to return -
ENOSYS
for
i40iw_create_ah(), nes_create_ah.
Will you please submit a fix that avoids above iWarp check?
i40iw_port_immutable sets the RDMA_CORE_PORT_IWARP immutable flag,
But when would someone create or initialize ah for iWarp port, given
than create_ah is unsupported.
AH type of RoCE for iWarp, doesn't sound correct.
I agree with Parav. Mapping iWarp to AH type RoCE doesn't make sense. IMO, iWarp should map to AH_ATTR_TYPE_UNDEFINED or something similar.
- Sean
Okay, I'll take care of it. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
