Re: [PATCH v4 rdma-next 17/18] IB/core: Define 'ib' and 'roce' rdma_ah_attr types

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 10/4/2017 2:24 PM, Parav Pandit wrote:
-----Original Message-----
From: linux-rdma-owner@xxxxxxxxxxxxxxx [mailto:linux-rdma-
owner@xxxxxxxxxxxxxxx] On Behalf Of Dasaratharaman Chandramouli
Sent: Saturday, April 29, 2017 1:41 PM
To: Doug Ledford <dledford@xxxxxxxxxx>
Cc: linux-rdma <linux-rdma@xxxxxxxxxxxxxxx>
Subject: [PATCH v4 rdma-next 17/18] IB/core: Define 'ib' and 'roce'
rdma_ah_attr types
+/*Get AH type */
+static inline enum rdma_ah_attr_type rdma_ah_find_type(struct ib_device
*dev,
+						       u32 port_num)
+{
+	if ((rdma_protocol_roce(dev, port_num)) ||
+	    (rdma_protocol_iwarp(dev, port_num)))
+		return RDMA_AH_ATTR_TYPE_ROCE;
Check for iWarp to define AH attribute type as RoCE appears error to me.
Taking quick look at i40iw and nes drivers appears to return -ENOSYS for i40iw_create_ah(), nes_create_ah.
Will you please submit a fix that avoids above iWarp check?


i40iw_port_immutable sets the RDMA_CORE_PORT_IWARP immutable flag, hence the check. Are you having an issue?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux