On Wed, Aug 23, 2017 at 10:45:33AM -0600, Jason Gunthorpe wrote:
> On Wed, Aug 23, 2017 at 07:32:17PM +0300, Leon Romanovsky wrote:
>
> > The commit sha1 should be 12 digits and not 7 digits.
>
> The github gui truncates to 7 digits when it detects a hash, the
> commit message has 12.
Thanks, applied.
BTW, do you know how to configure the gui?
>
> commit 39a612257aacd77ed5bdd506968cf4e54bbe63b3
> Author: Jeff Inman <jti@xxxxxxxx>
> Date: Tue Aug 22 15:59:42 2017 -0600
>
> rsockets: Fix segfaults when rs is not found in the index
>
> Check for null each time the rs is accessed and return an error code.
>
> Fixes: 0b6aff48ce31 ("librdmacm: Define streaming over RDMA interface (rsockets)")
> Fixes: bb9fcba81acd ("rsocket: Add APIs for direct data placement")
> Signed-off-by: Jeff Inman <jti@xxxxxxxx>
> Acked-by: Sean Hefty <sean.hefty@xxxxxxxxx>
> Signed-off-by: Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx>
>
> commit 5ac0576d51ddfb9207e5632c71d27d14b3368143
> Author: Jeff Inman <jti@xxxxxxxx>
> Date: Tue Aug 22 15:59:18 2017 -0600
>
> rsockets: Fix a race-condition in rs_free()
>
> If rs_free() releases the fd before calling rs_remove(), a second thread in
> rsocket() may acquire the same fd and store its own rs in the corresponding
> index-element. When the first thread then gets around to calling
> rs_remove() it ends up removing the rs of the second thread, and storing a
> NULL there.
>
> Several functions still do not check for NULL after retrieving an rs from
> the index for an open rsocket. Thus, the second thread would get a
> segfault in any of the following functions: rrecv, rrecvfrom, rsend,
> rsendto, rsendv, riomap, riounmap, riowrite.
>
> Fixes: cf7aae3d0cc4 ("rsocket: Index map item is cleaned before it is used in iomapping cleanup")
> Signed-off-by: Jeff Inman <jti@xxxxxxxx>
> Acked-by: Sean Hefty <sean.hefty@xxxxxxxxx>
> Signed-off-by: Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
