On Wed, Aug 23, 2017 at 07:29:27AM +0300, Leon Romanovsky wrote:
> On Tue, Aug 22, 2017 at 01:47:18PM -0600, Jeff Inman wrote:
> > Hi folks,
> >
> > I’m new to this. Please let me know, if you need a different format, etc.
>
> Yes,
>
> 1. Please send them with git send-email command, so they will be
> threaded together.
>
> 2. The commit messages should include description and you already have it
> here, just copy/paste to the commit message itself.
>
> 3. Fixes lines should be in the kernel format and not hand-made as it is now.
> The following git alias in your .gitconfig can create the proper Fixes line for the
> specific hash.
>
> [alias]
> fixes = log --abbrev=12 -1 --format='Fixes: %h (\"%s\")'
>
> For example: git fixes ac3a949fb2f in the kernel will produce:
> Fixes: ac3a949fb2ff ("IB/CM: Set appropriate slid and dlid when handling CM request")
>
> 4. No extra space between Fixes and your Signed-off-by signature.
>
> 5. Don't forget to add Sean's acked-by.
>
> Hope to see it merged.
Since we are so close to a release I made all the required changes and
sent a PR:
https://github.com/linux-rdma/rdma-core/pull/187
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
