On Thu, Aug 10, 2017 at 09:26:06PM +0000, Adit Ranadive wrote: > On 8/10/17, 2:01 PM, "Yuval Shaia" <yuval.shaia@xxxxxxxxxx> wrote: > > Great, i understand that. > > So, at least can you consider moving this dev_err into > > pvrdma_idx_ring_has_data so callers do not need to handle errors? > > Thanks for the suggestion. It's something we will have to discuss internally, > though I'm not sure if BUG_ON is the right way to go. That just seems a really No, i agree, BUG_ON is a mistake as ring corruption can be caused by HW, my suggestion is just to place the check and error print inside the function pvrdma_idx_ring_has_data so callers will not need to handle such errors. Anyways, with or without taking the suggestion - fix lgtm. Reviewed-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx> > big hammer to me. > As it stands the patch should be added since it does fix a potential race > condition. > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
