On 8/10/17, 2:01 PM, "Yuval Shaia" <yuval.shaia@xxxxxxxxxx> wrote: > Great, i understand that. > So, at least can you consider moving this dev_err into > pvrdma_idx_ring_has_data so callers do not need to handle errors? Thanks for the suggestion. It's something we will have to discuss internally, though I'm not sure if BUG_ON is the right way to go. That just seems a really big hammer to me. As it stands the patch should be added since it does fix a potential race condition. ��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f