On Mon, Jul 31, 2017 at 10:02:08PM +0300, Dan Carpenter wrote:
> On Mon, Jul 31, 2017 at 07:21:33PM +0300, Leon Romanovsky wrote:
> > On Mon, Jul 31, 2017 at 10:09:18AM +0300, Leon Romanovsky wrote:
> > > From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> > >
> > > The smatch complains about possible dereference, it is unclear from
> > > source how it can occur, since in case of failure to find/allocate
> > > group, the acquire_group() will return error.
> > >
> > > Avoid the following error, by changing IS_ERR() to be IS_ERR_OR_NULL().
> > >
> > > drivers/infiniband/hw/mlx4/mcg.c:964 mlx4_ib_mcg_multiplex_handler() error:
> > > potential null dereference 'group'. (acquire_group returns null)
> > >
> > > Fixes: b9c5d6a64358 ("IB/mlx4: Add multicast group (MCG) paravirtualization for SR-IOV")
> > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> > > ---
> > > drivers/infiniband/hw/mlx4/mcg.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> >
> > Hi Dan,
> >
> > Bart [1] and me both believe that smatch tool is incorrectly reported error.
> > Do you think that the tool should be fixed?
> >
>
> Yeah. There are two functions called acquire_group() and one returns
> NULL and one returns error pointers. It's getting them mixed up.
> It's simple enough to silence the warning. I'll push that tomorrow.
>
> I normally run with the cross function database so I don't see this
> warning on my builds. The cross function DB doesn't get confused when
> there are two functions with the same name.
Thanks
>
> regards,
> dan carpenter
Attachment:
signature.asc
Description: PGP signature
