From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
The smatch complains about possible dereference, it is unclear from
source how it can occur, since in case of failure to find/allocate
group, the acquire_group() will return error.
Avoid the following error, by changing IS_ERR() to be IS_ERR_OR_NULL().
drivers/infiniband/hw/mlx4/mcg.c:964 mlx4_ib_mcg_multiplex_handler() error:
potential null dereference 'group'. (acquire_group returns null)
Fixes: b9c5d6a64358 ("IB/mlx4: Add multicast group (MCG) paravirtualization for SR-IOV")
Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
---
drivers/infiniband/hw/mlx4/mcg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/mlx4/mcg.c b/drivers/infiniband/hw/mlx4/mcg.c
index b73f89700ef9..9c26a6837c62 100644
--- a/drivers/infiniband/hw/mlx4/mcg.c
+++ b/drivers/infiniband/hw/mlx4/mcg.c
@@ -956,7 +956,7 @@ int mlx4_ib_mcg_multiplex_handler(struct ib_device *ibdev, int port,
mutex_lock(&ctx->mcg_table_lock);
group = acquire_group(ctx, &rec->mgid, may_create, GFP_KERNEL);
mutex_unlock(&ctx->mcg_table_lock);
- if (IS_ERR(group)) {
+ if (IS_ERR_OR_NULL(group)) {
kfree(req);
return PTR_ERR(group);
}
--
2.13.3
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
