On Tue, 2017-07-25 at 11:44 -0600, Jason Gunthorpe wrote: > On Tue, Jul 25, 2017 at 05:28:10PM +0000, Bart Van Assche wrote: > > On Tue, 2017-07-25 at 11:17 -0600, Jason Gunthorpe wrote: > > > On Tue, Jul 25, 2017 at 04:47:59PM +0000, Bart Van Assche wrote: > > > > LOG_PERROR is very convenient when debugging srp_daemon. How about using > > > > the result of isatty(STDERR_FILENO) to decide whether or not to enable > > > > LOG_PERROR? > > > > > > How about a --debug option that sets > > > > > > s_log_dest = log_to_stderr; > > > > Sorry but I prefer that LOG_PERROR is retained when srp_daemon is started in > > another way than by systemd. How about adding StandardError=null to the > > srp_daemon unit file? > > No, then emergency prints from libraries are lost forever eg glibc > malloc corruption prints. > > How about a --systemd option? I think we are going to want that anyhow > down the road. Hello Jason, That sounds fine to me. Thanks, Bart.-- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
