Re: [PATCH rdma-core 16/21] srp_daemon: Do not use LOG_PERROR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 25, 2017 at 04:47:59PM +0000, Bart Van Assche wrote:

> LOG_PERROR is very convenient when debugging srp_daemon. How about using
> the result of isatty(STDERR_FILENO) to decide whether or not to enable
> LOG_PERROR?

How about a --debug option that sets

  s_log_dest = log_to_stderr;

?

> All the other srp_daemon-related patches in this series look fine to me.
> Thank you for having done this work!

Great, thanks, I'll add your Reviewed-by to SRP patches then?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux