Re: Issues with starting srp_daemon userspace for a 4.13 kernel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 07/19/2017 03:49 PM, Jason Gunthorpe wrote:
On Wed, Jul 19, 2017 at 03:40:06PM -0400, Laurence Oberman wrote:

Jason did I misunderstand you.
That you were saying this patch was the issue.
I thought you were saying this was the fix.

Er, that isn't the patch I quoted, that is the broken patch the patch
I quoted fixes:

Subject: [PATCH v2 1/2] RDMA/uverbs: Fix the check for port number

The port number is only valid if IB_QP_PORT is set in the mask.
So only check port number if it is valid to prevent modify_qp from
failing due to an invalid port number.

Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds")
Cc: <stable@xxxxxxxxxxxxxxx> # v2.6.14+
Reviewed-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Mustafa Ismail <mustafa.ismail@xxxxxxxxx>

You need the above if you have 5ecce4c9b17b in your tree.

Not sure why it still doesn't seem to be in Linus's tree...

Jason


Groan!!
Apologies,
I grabbed the bad patch commit id when you first responded
5ecce4c9b17b

So that bad patch is in 4.12 and 4.13
Instead of searching for the patch String that fixed it in your original message

OK, makes sense now
Nevertheless, needs to go into Linus's tree as you called out.
Thanks
Sorry for the noise
Laurence
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux