On Thu, Jul 06, 2017 at 02:47:33PM +0300, Leon Romanovsky wrote: > > It works by chance, assuming that "->raw" will be always first member is > not a good strategy, so I agree with Dan. It is NULL dereferencing. > How these false positives normally look is like this: struct whatever *p = foo->bar; if (!foo) return -EINVAL; It looks like a dereference but isn't. And in this case it doesn't matter if it's the first member or not. Anyway, just from a correctness point of view it's better to not print false positives. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html