> -----Original Message----- > From: Leon Romanovsky [mailto:leon@xxxxxxxxxx] > Subject: Re: [bug report] IB/mlx5: Respect mlx5_core reserved GIDs > > On Thu, Jul 06, 2017 at 02:44:59PM +0300, Dan Carpenter wrote: > > Ah... You're right, of course. I've been meaning to fix those false > > positives for a while. > > > > The only problem is that how would I still catch the bug if ->raw wasn't > > the first member... I need to think about that some more... > > I think that you should report all those cases without relation > to first/not first member. I must agree with Leon. The fact that it doesn't dereference a NULL now, doesn't mean it's not bug, lurking to crash at the next patch, and no other review will ever find it. > > > > > regards, > > dan carpenter > > ��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
