On Wed, Jun 28, 2017 at 10:02:51AM -0600, Jason Gunthorpe wrote: > On Wed, Jun 28, 2017 at 04:34:43PM +0300, Leon Romanovsky wrote: > > > + /* > > + * Subnet prefix (in host byte order) > > + */ > > + RDMA_NLDEV_ATTR_SUBNET_PREFIX, /* u64 */ > > I've always hated how random the be / host choices are in our API. Agree > > Since the GUID is in host order I recommend making the subnet_prefix > in host order too. > > At the very least, the comments beside anything not in host order > should be 'be64' not u64 Those comments represent netlink types. It doesn't have be64. > > Jason
Attachment:
signature.asc
Description: PGP signature
