On Wed, Jun 14, 2017 at 7:26 AM, Somnath Kotur <somnath.kotur@xxxxxxxxxxxx> wrote: > On Wed, Jun 14, 2017 at 12:50 AM, Jason Gunthorpe > <jgunthorpe@xxxxxxxxxxxxxxxxxxxx> wrote: >> On Tue, Jun 13, 2017 at 09:03:25AM +0300, Leon Romanovsky wrote: >>> On Tue, Jun 13, 2017 at 08:24:51AM +0530, Somnath Kotur wrote: >>> > Currently sgid_index is of type 'u8' so we can't really go beyond 128 >>> > unique GID entries(one for each type so total of 256 GID entries). >>> > Change it to u16 so atleast 4k GID entries (as many VLANs that can be added) >>> > can be accomodated. >>> > >>> > Signed-off-by: Somnath Kotur <somnath.kotur@xxxxxxxxxxxx> >>> > drivers/infiniband/core/verbs.c | 2 +- >>> > include/rdma/ib_verbs.h | 4 ++-- >>> > 2 files changed, 3 insertions(+), 3 deletions(-) >>> >>> What type of testing did this change get? >>> According to spec, "The maximum number (N) of unicast GIDs supported per endport is >>> implementation specific". >>> >>> mlx5 and mlx4 are limited to 128 GIDs and user will get errors if he try to set >>> more than that. >> >> At a minimum I think this patch will need to add overflow protection >> on the uapi paths that cast this back to a u8, and Matan should >> consider expanding sgid_index to u16 in the new uapi, whenever >> possible.. >> Yep, let's get the infrastructure in and then discuss verb-by-verb basis. Seems very reasonable extending it to 16bit. >> .. and Somnath you should review Matan's uABI patches since you want >> such a fundamental change :) >> >> Jason > Sure, thanks for your comments Jason. Will check with Matan on this > In (very) short - we propose a new ioctl based ABI that uses attributes (instead of one struct-per-command). This is easier to extend and more flexible than the current schema. Since we change the whole ABI, we could think of fields which should be extended and apply that change to the new ABI. You could review this work [1]. > Thanks > Som > -- Regards, Matan [1] https://www.spinics.net/lists/linux-rdma/msg50631.html > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
