On Wed, Jun 14, 2017 at 12:50 AM, Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx> wrote: > On Tue, Jun 13, 2017 at 09:03:25AM +0300, Leon Romanovsky wrote: >> On Tue, Jun 13, 2017 at 08:24:51AM +0530, Somnath Kotur wrote: >> > Currently sgid_index is of type 'u8' so we can't really go beyond 128 >> > unique GID entries(one for each type so total of 256 GID entries). >> > Change it to u16 so atleast 4k GID entries (as many VLANs that can be added) >> > can be accomodated. >> > >> > Signed-off-by: Somnath Kotur <somnath.kotur@xxxxxxxxxxxx> >> > drivers/infiniband/core/verbs.c | 2 +- >> > include/rdma/ib_verbs.h | 4 ++-- >> > 2 files changed, 3 insertions(+), 3 deletions(-) >> >> What type of testing did this change get? >> According to spec, "The maximum number (N) of unicast GIDs supported per endport is >> implementation specific". >> >> mlx5 and mlx4 are limited to 128 GIDs and user will get errors if he try to set >> more than that. > > At a minimum I think this patch will need to add overflow protection > on the uapi paths that cast this back to a u8, and Matan should > consider expanding sgid_index to u16 in the new uapi, whenever > possible.. > > .. and Somnath you should review Matan's uABI patches since you want > such a fundamental change :) > > Jason Sure, thanks for your comments Jason. Will check with Matan on this Thanks Som -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
