On Tue, Jun 06, 2017 at 03:36:59PM +0000, Bart Van Assche wrote: > On Tue, 2017-06-06 at 15:38 +0300, Yuval Shaia wrote: > > Logic of retriving netdev speed from net_device and translating it to IB > > speed is implemented both in rxe and bnxt drivers. > > Hello Yuval, > > Have you noticed that there is another copy of eth_speed_to_ib_speed() in > the usnic driver? Missed that one. I will post v1 of the patch soon that utilize this new function in usnic_ib_query_port. Problem i see here is that usnic_ib_query_port directly call __ethtool_get_link_ksettings and not via netdev->ethtool_ops. So asking usnic folks to review and approve the change. > > Bart.-- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html