On Tue, May 30, 2017 at 01:51:33PM +0300, Sagi Grimberg wrote: > Leon, > > > > We don't fence those WR's. > > > Christoph just re-write it to be more intuitive code. I don't see logic > > > difference, am I wrong here ? > > > > A little bit, before Christoph's suggestion, we calculated fence for > > the paths which need such fence, after we will calculate for all paths. > > Every WQE posted to a send queue must include a fence bit. All work > request posted on the send queue calculate the required fence, this > used to happen in finish_wqe call-sites with get_fence(), Christoph > just inlin'ed it. Sagi, Thanks, I found my mistake, I saw that IB_SEND_INLINE WR doesn't call to get_fence and we have an if() which can skip finish_wqe, so I thought that finish_wqe isn't called always, however it was for error path. Thanks again.
Attachment:
signature.asc
Description: PGP signature
