Re: [PATCH v2 19/20] IB/rdmavt, IB/qib, IB/hfi1: Make percpu refcount optional for user MRs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 06, 2017 at 05:16:31PM +0000, Marciniszyn, Mike wrote:
> > > There were two patches in the patch series, one reworks the rdmavt
> > > read side MR to allow for getting rid of an explicit RCU at deref
> > > time.  The second module parameter was intended to allow for a faster
> > > memory registration for user MRs as an option.
> > 
> > If it is faster why wouldn't you always just use that mode?
> 
> It would be faster mr deregistration, but slower data patch since
> atomic operations would then be done.

Umm.. This doesn't look like a refcount, it is a rwlock - why aren't
you using the optimized percpu_rwsem?

Seriously, making a rwlock out of a completion and a percpu_refcount
and then providing user options to micro-optimize it is fantastically
ugly/bad taste.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux