On Wed, Apr 5, 2017 at 10:46 PM, Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx> wrote: > On 04/05/2017 02:38 PM, Doug Ledford wrote: >> >> On Mon, 2017-03-20 at 17:26 -0700, Dennis Dalessandro wrote: >>> >>> +static unsigned int hfi1_no_user_mr_percpu; >>> +module_param_named(no_user_mr_percpu, hfi1_no_user_mr_percpu, uint, >>> + S_IRUGO); >>> +MODULE_PARM_DESC(no_user_mr_percpu, >>> + "Avoid percpu refcount for user MRs (default 0)"); >>> + >> >> >> Does this have to be a module parameter? Those are frowned upon now a >> days... >> > > Yeah I don't like it either really, but there is a pretty big tradeoff > between memory deregistration improvement and cost to the data path. Most > use cases care about the data path but some uses register and deregister > memory a lot and this helps them. > > Is there a another way we should be looking at for setting things like this? Use vendor channel interface to configure your driver. > > -Denny > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
