On Wed, Apr 5, 2017 at 9:38 PM, Doug Ledford <dledford@xxxxxxxxxx> wrote: > On Mon, 2017-03-20 at 17:26 -0700, Dennis Dalessandro wrote: >> +static unsigned int hfi1_no_user_mr_percpu; >> +module_param_named(no_user_mr_percpu, hfi1_no_user_mr_percpu, uint, >> + S_IRUGO); >> +MODULE_PARM_DESC(no_user_mr_percpu, >> + "Avoid percpu refcount for user MRs (default 0)"); >> + > > Does this have to be a module parameter? Those are frowned upon now a > days... Good catch, no way that driver will require module parameter which is a headache to set while it is compiled into kernel. > > -- > Doug Ledford <dledford@xxxxxxxxxx> > GPG KeyID: B826A3330E572FDD > > Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
