On Thu, Mar 23, 2017 at 06:21:09PM +0000, Alex Margolin wrote: > > > > From: Jason Gunthorpe [mailto:jgunthorpe@xxxxxxxxxxxxxxxxxxxx] > > Sent: Monday, February 06, 2017 12:44 AM > > To: Alex Margolin <alexma@xxxxxxxxxxxx> > > Cc: linux-rdma@xxxxxxxxxxxxxxx > > Subject: Re: [RFC] Registering non-contiguous memory > > > > On Sun, Feb 05, 2017 at 04:46:04PM +0000, Alex Margolin wrote: > > > > > +struct verbs_mw { > > > + struct ibv_mw mw; > > > + uint32_t comp_mask; > > > + uint32_t lkey; > > > + uint32_t descriptor_num; > > > +}; > > > > Just as a general comment for all future patches - now that the provider > > interface is private I don't want to see 'comp_mask' stuff in driver.h > > How else would we support future extensibility otherwise? It seems > that all the other structs in driver.h have comp_mask: struct > verbs_xrcd, struct verbs_srq and struct verbs_qp. comp_mask was originaly to support ABI change, but the driver ABI is now private so we do not need it in driver.h. If you need optional things then a 'flags' or a NULL value is the way to go. It is hard to understand what you are proposing here since verbs_mw wasn't even used in the patch. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
