> -----Original Message----- > From: Jason Gunthorpe [mailto:jgunthorpe@xxxxxxxxxxxxxxxxxxxx] > Sent: Monday, February 06, 2017 12:44 AM > To: Alex Margolin <alexma@xxxxxxxxxxxx> > Cc: linux-rdma@xxxxxxxxxxxxxxx > Subject: Re: [RFC] Registering non-contiguous memory > > On Sun, Feb 05, 2017 at 04:46:04PM +0000, Alex Margolin wrote: > > > +struct verbs_mw { > > + struct ibv_mw mw; > > + uint32_t comp_mask; > > + uint32_t lkey; > > + uint32_t descriptor_num; > > +}; > > Just as a general comment for all future patches - now that the provider > interface is private I don't want to see 'comp_mask' stuff in driver.h How else would we support future extensibility otherwise? It seems that all the other structs in driver.h have comp_mask: struct verbs_xrcd, struct verbs_srq and struct verbs_qp. > > > > @@ -1411,11 +1478,13 @@ enum verbs_context_mask { > > VERBS_CONTEXT_QP = 1 << 2, > > VERBS_CONTEXT_CREATE_FLOW = 1 << 3, > > VERBS_CONTEXT_DESTROY_FLOW = 1 << 4, > > - VERBS_CONTEXT_RESERVED = 1 << 5 > > + VERBS_CONTEXT_ALLOC_MW = 1 << 5, > > + VERBS_CONTEXT_RESERVED = 1 << 6 > > }; > > What is this reserved thing? Note that this reserved bit was there before the patch... I just left it there. > > Don't forget man pages are required. > > Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
