polling the completion queue directly does not interfere with the existing polling logic, hence drop the requirement. This can be used for polling mode ULPs. Signed-off-by: Sagi Grimberg <sagi@xxxxxxxxxxx> --- drivers/infiniband/core/cq.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/infiniband/core/cq.c b/drivers/infiniband/core/cq.c index 21d1a38af489..7f6ae0ecb0c5 100644 --- a/drivers/infiniband/core/cq.c +++ b/drivers/infiniband/core/cq.c @@ -64,8 +64,6 @@ static int __ib_process_cq(struct ib_cq *cq, int budget) */ int ib_process_cq_direct(struct ib_cq *cq, int budget) { - WARN_ON_ONCE(cq->poll_ctx != IB_POLL_DIRECT); - return __ib_process_cq(cq, budget); } EXPORT_SYMBOL(ib_process_cq_direct);Using ib_process_cq_direct() for queues that have another type than IB_POLL_DIRECT may trigger concurrent CQ processing.
Correct.
Before this patch the completions from each CQ were processed sequentially. That's a big change so I think this should be mentioned clearly in the header above ib_process_cq_direct().
Note that I now see that the cq lock is not sufficient for mutual exclusion here because we're referencing cq->wc array outside of it. There are three options I see here: 1. we'll need to allocate a different wc array for polling mode, perhaps a smaller one? 2. Export __ib_process_cq (in some form) with an option to pass in a wc array. 3. Simply not support non-selective polling but it seems like a shame... Any thoughts? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
