On Thu, 2017-03-09 at 16:04 -0700, Jason Gunthorpe wrote: > On Thu, Mar 09, 2017 at 10:53:31PM +0000, Bart Van Assche wrote: > > Sorry, I used the wrong base for the diff command. How about the patch below > > to fix the SuSE build: > > Are you using an older suse? I just updated my tumbleweed image and it > built fine with HEAD. > > What is in your /etc/rpm/macros.cmake? All the suse's I looked at have > this in that file: > > %cmake_install \ > DESTDIR=%{buildroot} %__builder install -C %__builddir > > It comes from here (tumbleweed): > > builder-40f0d1607cec:/etc/rpm # rpm -qf /etc/rpm/macros.cmake > cmake-3.7.2-1.1.x86_64 > > (13.2): > > bash-4.2# rpm -qf /etc/rpm/macros.cmake > cmake-3.0.2-6.1.x86_64 > > ? > > I also checked and it built OK on OpenSuse 13.2 > > So.. I'm confused what we are trying to fix here? :) Hello Jason, Without that patch building an RPM fails against a recent version of Tumbleweed: $ rpm -qf /etc/issue.net openSUSE-release-20170304-1.1.x86_64 $ rpm -qf /etc/rpm/macros.cmake cmake-3.7.2-1.1.x86_64 $ cat ./build-rpm.sh #!/bin/sh name=rdma-core version=$(sed -n 's/^Version:[[:blank:]]*//p' rdma-core.spec) rpmtopdir=$PWD/rpmbuilddir git archive --prefix rdma-core-${version}/ --output ${name}-${version}.tgz HEAD && rm -rf ${rpmtopdir} && mkdir -p ${rpmtopdir}/{BUILD,RPMS,SOURCES,SPECS,SRPMS} && cp ${name}-${version}.tgz ${rpmtopdir}/SOURCES && rpmbuild --define="%_topdir ${rpmtopdir}" -ba ${name}.spec $ ./build-rpm.sh [ ... ] -- Build files have been written to: rdma-core/rpmbuilddir/BUILD/rdma-core-13/build + /usr/bin/make -j4 VERBOSE=1 make: *** No targets specified and no makefile found. Stop. error: Bad exit status from /var/tmp/rpm-tmp.4zaz5Y (%build) Bart.-- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html