On Thu, 2017-03-09 at 15:49 -0700, Jason Gunthorpe wrote:
> On Thu, Mar 09, 2017 at 10:35:30PM +0000, Bart Van Assche wrote:
> > Something else is also broken, namely the SuSE section in rdma-core.spec. I
> > just figured out that the following is needed to build an RPM on SuSE systems:
> >
> > diff --git a/rdma-core.spec b/rdma-core.spec
> > index f7a440d7..aa486371 100644
> > +++ b/rdma-core.spec
> > @@ -28,7 +28,7 @@ BuildRequires: ninja,make
> > %define __builder ninja
> > # cmake_install,make_jobs is specified by opensuse
> > %define cmake cmake
> > -%define cmake_install DESTDIR=%{buildroot} ninja install
> > +%define cmake_install DESTDIR=%{buildroot} make install
>
> I'm not sure what tree you are looking at? The above '-' line never
> appeared in mainline?
>
> The opensuse rpm macros themselves are supposed to provide
> cmake_install, so the spec file should not define it. Did they change
> their macros again or something?
>
> We provide it for the RH cases because they use a different cmake rpm
> macro set. :(
Hello Jason,
Sorry, I used the wrong base for the diff command. How about the patch below
to fix the SuSE build:
diff --git a/rdma-core.spec b/rdma-core.spec
index 6519bc37..aa486371 100644
--- a/rdma-core.spec
+++ b/rdma-core.spec
@@ -27,6 +27,8 @@ BuildRequires: valgrind-devel
BuildRequires: ninja,make
%define __builder ninja
# cmake_install,make_jobs is specified by opensuse
+%define cmake cmake
+%define cmake_install DESTDIR=%{buildroot} make install
# Tumbleweed's cmake RPM macro adds -Wl,--no-undefined to the module flags
# which is totally inappropriate and breaks building 'ENABLE_EXPORTS' style
Thanks,
Bart.--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
