On Wed, Feb 08, 2017 at 12:28:50AM -0800, Christoph Hellwig wrote:
> > #include <linux/types.h>
> > -#include <rdma/ib_verbs.h>
> >
> > /*
> > * Increment this value if any changes that break userspace ABI
> > @@ -548,11 +547,11 @@ enum {
> > };
> >
> > enum {
> > - IB_USER_LEGACY_LAST_QP_ATTR_MASK = IB_QP_DEST_QPN
> > + IB_USER_LEGACY_LAST_QP_ATTR_MASK = 1ULL << 20,
> > };
> >
> > enum {
> > - IB_USER_LAST_QP_ATTR_MASK = IB_QP_RATE_LIMIT
> > + IB_USER_LAST_QP_ATTR_MASK = 1ULL << 25,
>
> I disagree with the upendcoding. These constant should be moved to
> the user verbs header instead.
These constants are part of much larger enum ib_qp_attr_mask. IMHO copy
two values from that enum isn't good, but copy whole enum (mostly not
needed for the users) is bad either. So I decided to open code it as a fix
for -rc7.
Thanks
Attachment:
signature.asc
Description: PGP signature
